refactor(sdk-analytics): Consolidate analytics data attributes and simplify Contentlet component

[oidacra]

Summary

Consolidates analytics data attributes by moving constants from UVE to sdk-analytics and simplifies the sdk-react Contentlet component by removing redundant analytics state management. Analytics attributes now always render using UVE's standard contentlet attributes instead of separate conditional logic.

Changes Made

SDK Analytics (libs/sdk/analytics)

• Moved analytics constants from @dotcms/uve/internal to sdk-analytics/constants:

  • ANALYTICS_WINDOWS_ACTIVE_KEY - Analytics active state flag
  • ANALYTICS_WINDOWS_CLEANUP_KEY - Analytics cleanup function reference
  • CONTENTLET_CLASS - Renamed from ANALYTICS_CONTENTLET_CLASS to dotcms-contentlet

• Updated data attribute naming to use standard UVE attributes:

  • data-dot-analytics-identifier → data-dot-identifier
  • data-dot-analytics-inode → data-dot-inode
  • data-dot-analytics-contenttype → data-dot-type
  • data-dot-analytics-title → data-dot-title
  • data-dot-analytics-basetype → data-dot-basetype
  • data-dot-analytics-dom-index → data-dot-dom-index

• Updated all analytics plugins to use consolidated constants and new attribute names:

  • dot-analytics.content.ts
  • dot-analytics.identity.activity-tracker.ts
  • dot-analytics.impression-tracker.ts
  • dot-analytics.utils.ts

SDK React (libs/sdk/react)

• Removed useIsAnalyticsActive hook (useIsAnalyticsActive.ts)

  • No longer needed since analytics attributes always render via UVE

• Simplified Contentlet component (Contentlet.tsx:55-78):

  • Removed conditional analyticsAttributes useMemo
  • Removed conditional containerClassName useMemo
  • Removed isAnalyticsActive state check
  • Always applies UVE attributes via getDotContentletAttributes()
  • Always applies CONTENTLET_CLASS (dotcms-contentlet)

• Updated tests (Contentlet.test.tsx):

  • Removed useIsAnalyticsActive mock
  • Removed getDotAnalyticsAttributes mock
  • Updated assertions to reflect always-rendered attributes
  • Simplified test cases (removed analytics conditional tests)

SDK UVE (libs/sdk/uve)

• Removed analytics-specific exports from UVE internal API:
  • Removed getDotAnalyticsAttributes() function (analytics now uses standard UVE attributes)
  • Removed isAnalyticsActive() function (no longer needed)
  • Removed ANALYTICS_WINDOWS_ACTIVE_KEY and ANALYTICS_WINDOWS_CLEANUP_KEY constants (moved to sdk-analytics)
  • Removed 50+ lines of analytics-specific tests

Technical Details

Problem: The sdk-react Contentlet component had duplicate analytics attribute logic that conditionally rendered based on isAnalyticsActive && !isDevMode. This created complexity and separated analytics attributes from UVE's standard contentlet attributes.

Solution:

1. Consolidate analytics constants in @dotcms/analytics where they belong
2. Use UVE's standard getDotContentletAttributes() which already provides all necessary data attributes
3. Remove conditional rendering - analytics attributes always render via the standard data-dot-* attributes
4. Standardize CSS class to dotcms-contentlet (used by both UVE and analytics)

Benefits:

• Simpler component logic - No analytics state management needed
• Consistent data attributes - Single source of truth (UVE)
• Better separation of concerns - Analytics constants live in analytics SDK
• Always-on tracking - Analytics attributes always present (no missed tracking events)

Breaking Changes

CSS Class Change: The analytics contentlet class changed from dotcms-analytics-contentlet to dotcms-contentlet. This aligns with UVE's standard class and should not affect existing implementations as both classes serve the same selector purpose.

Data Attribute Changes: Analytics data attributes now use standard UVE naming (data-dot-* instead of data-dot-analytics-*). The analytics SDK internally handles reading these attributes, so no client-side changes are needed.

Testing

• Unit tests updated for Contentlet component
• Unit tests updated for analytics plugins (impression tracker, identity tracker)
• Removed obsolete analytics state tests
• All tests passing

Related Issues

Closes #33947

Additional Notes

This refactoring aligns with the strategy to consolidate analytics functionality and reduce code duplication across the SDK. Future enhancements can build on this simplified foundation without managing separate analytics attribute logic.

The change ensures analytics tracking is always active and consistent, removing edge cases where analytics might be disabled outside Edit Mode.

This PR fixes: #33947

[Copilot]

Pull request overview

This PR consolidates analytics-related constants and data attributes to simplify the architecture across SDK packages. The main goal is to eliminate duplicate analytics logic in the React Contentlet component by standardizing on UVE's data attributes (data-dot-*) instead of maintaining separate analytics-specific attributes (data-dot-analytics-*).

Key changes:

• Moved analytics window constants from @dotcms/uve/internal to @dotcms/analytics for better separation of concerns
• Standardized data attribute names to use UVE's data-dot-* pattern across all analytics plugins
• Removed conditional analytics state management from React's Contentlet component (now always renders UVE attributes)

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
core-web/libs/sdk/uve/src/lib/dom/dom.utils.ts	Removed getDotAnalyticsAttributes() helper function (analytics now uses standard UVE attributes)
core-web/libs/sdk/uve/src/lib/core/core.utils.ts	Removed isAnalyticsActive() utility function (no longer needed for conditional rendering)
core-web/libs/sdk/uve/src/lib/core/core.spec.ts	Removed 50+ lines of tests for deleted isAnalyticsActive() function
core-web/libs/sdk/uve/src/internal/constants.ts	Removed analytics constants ANALYTICS_WINDOWS_ACTIVE_KEY and ANALYTICS_WINDOWS_CLEANUP_KEY (moved to analytics SDK)
core-web/libs/sdk/react/src/lib/next/hooks/useIsAnalyticsActive.ts	Deleted entire hook file (76 lines) - no longer needed for conditional rendering
core-web/libs/sdk/react/src/lib/next/components/Contentlet/Contentlet.tsx	Simplified component by removing analytics state checks and always applying UVE attributes; added CONTENTLET_CLASS constant
core-web/libs/sdk/react/src/lib/next/__test__/components/Contentlet.test.tsx	Updated tests to reflect simplified logic - removed analytics mocks and updated assertions
core-web/libs/sdk/analytics/src/lib/core/shared/constants/dot-analytics.constants.ts	Added ANALYTICS_WINDOWS_ACTIVE_KEY, ANALYTICS_WINDOWS_CLEANUP_KEY, and CONTENTLET_CLASS constants
core-web/libs/sdk/analytics/src/lib/core/shared/utils/dot-analytics.utils.ts	Updated attribute reading to use standard data-dot-* names instead of data-dot-analytics-*
core-web/libs/sdk/analytics/src/lib/core/plugin/impression/dot-analytics.impression-tracker.ts	Updated to use data-dot-dom-index instead of data-dot-analytics-dom-index
core-web/libs/sdk/analytics/src/lib/core/plugin/impression/dot-analytics.impression-tracker.spec.ts	Updated test fixtures to use new attribute names and CONTENTLET_CLASS
core-web/libs/sdk/analytics/src/lib/core/plugin/identity/dot-analytics.identity.activity-tracker.ts	Updated imports to reference constants from analytics SDK instead of UVE
core-web/libs/sdk/analytics/src/lib/core/plugin/identity/dot-analytics.identity.activity-tracker.spec.ts	Updated imports to reference constants from analytics SDK instead of UVE
core-web/libs/sdk/analytics/src/lib/core/dot-analytics.content.ts	Updated imports to reference constants from analytics SDK instead of UVE

---

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[nicobytes]

The DotAnalyticsAttributes type definition still references the old attribute naming convention:

 type AnalyticsAttribute<T extends string> = `data-dot-analytics-${T}`;

  export type DotAnalyticsAttributes = {
      [K in AnalyticsAttributeKey as AnalyticsAttribute<K>]: string;
  };

[nicobytes]

In libs/sdk/analytics/README.md I found 3 references to old naming conventions:

• Line 250: References dotcms-analytics-contentlet class and data-dot-analytics-* attributes
• Line 302: References dotcms-analytics-contentlet class and data-dot-analytics-* attributes
• Line 344: References data-dot-analytics-* attributes

done.