Conversation
gewarren
requested review from
ReubenBond,
meaghanlewis and
tommcdon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reorganizes the logging documentation by moving all logging-related docs and snippets into a dedicated "logging" subfolder under docs/core/extensions/. The PR also modernizes the high-performance logging documentation to prioritize source-generated logging (using LoggerMessageAttribute) over the legacy LoggerMessage.Define approach.
Changes:
- Moved 9 logging documentation files to
docs/core/extensions/logging/subfolder with appropriate redirections - Rewrote
high-performance-logging.mdto focus on source-generated logging as the primary approach, relegatingLoggerMessage.Defineto a legacy section - Updated 30+ files with corrected path references to moved logging documentation
Reviewed changes
Copilot reviewed 39 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
high-performance-logging.md |
Complete rewrite focusing on source-generated logging with LoggerMessageAttribute as primary approach |
source-generation.md |
Updated snippet paths to reflect new folder structure |
overview.md |
Updated relative paths for snippets and cross-references |
providers.md |
Updated relative paths for snippets and cross-references |
console-log-formatter.md |
Updated relative paths and improved wording |
custom-provider.md |
Updated relative paths and improved contractions |
library-guidance.md |
Updated relative paths and improved style |
log-sampling.md |
Updated relative paths throughout |
log-buffering.md |
Updated relative paths throughout |
.openpublishing.redirection.core.json |
Added 9 redirect entries for moved files |
| Multiple cross-referencing files | Updated 20+ files to reference new logging documentation paths |
| Project files | Updated target frameworks to net10.0 (may need review) |
Comments suppressed due to low confidence (1)
docs/core/extensions/logging/console-log-formatter.md:14
- According to Markdown Writing Style Guidelines (Guideline 1000002), avoid using "you will" in instructions. Change "you will learn" to present tense "you learn" or use imperative mood. The sentence should read "In this article, you learn about console log formatters."
gewarren
commented
Feb 3, 2026
Contributor
Author
|
Thanks @BillWagner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #51382.
Fixes #40870.
Internal previews
Toggle expand/collapse
BackgroundService