Conversation
Lazy allocation for coefficient in a readonly struct with static constructor Allocation and computation is done only once, first time we invoke erfinv On the other side, 8kb won't be collected
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7569 +/- ##
==========================================
- Coverage 69.02% 69.02% -0.01%
==========================================
Files 1482 1482
Lines 274096 274099 +3
Branches 28266 28266
==========================================
- Hits 189191 189187 -4
- Misses 77518 77526 +8
+ Partials 7387 7386 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Author
|
There was no tests before. Should I add some ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before :
an array of 1000 double is allocated and computed for each erfinv call
Now :
Lazy allocation for coefficient in a readonly struct with static constructor
Allocation and computation is done only once, first time we invoke erfinv
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.