Fix bug that causes Merge to fail with empty DataFrames#7573
Merged
tarekgh merged 2 commits intodotnet:mainfrom Feb 5, 2026
Merged
Fix bug that causes Merge to fail with empty DataFrames#7573tarekgh merged 2 commits intodotnet:mainfrom
tarekgh merged 2 commits intodotnet:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7573 +/- ##
==========================================
+ Coverage 69.02% 69.07% +0.04%
==========================================
Files 1482 1483 +1
Lines 274099 274362 +263
Branches 28266 28270 +4
==========================================
+ Hits 189199 189503 +304
+ Misses 77518 77478 -40
+ Partials 7382 7381 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Looks like some builds timed out, which doesn't appear to be related to my commit. Is there some way to run them again? |
This was referenced Jan 28, 2026
Open
Contributor
Author
|
@tarekgh I see that you have been active in this repo recently. Are you able to review this PR or point me to someone who can? |
Member
|
Thanks @sevenzees! @ericstj the change LGTM. Please let me know if you have any feedback or we are good to merge. Thanks! CC @jeffhandley |
tarekgh
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7572
When using the DataFrame Merge method, if one of the DataFrames is empty (has no rows), you will get a System.ArgumentOutOfRangeException. This was caused by the Clone method trying to access the first element of the empty Buffers array. It is easily fixed by returning an empty container of the appropriate length when Buffers.Count == 0.