Skip to content

Fix bug with optional Arguments becoming required #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dotnetKyle merged 1 commit into from
Nov 14, 2025
Merged

Fix bug with optional Arguments becoming required #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MinimalCli.SourceGenerator/GeneratorBindingsProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ private static void BindServiceDescriptor(this List<ParameterBinding> list, stri

private static string? GetSymbolDefaultValue(GeneratorAttributeSyntaxContext ctx, IParameterSymbol param)
{
static string FormatLiteral(object value)
static string FormatLiteral(object? value)
{
return value switch
{
Expand All @@ -245,7 +245,7 @@ static string FormatLiteral(object value)
};
}

if (param.HasExplicitDefaultValue && param.ExplicitDefaultValue is not null)
if (param.HasExplicitDefaultValue)
{
SyntaxReference? syntaxRef = param.DeclaringSyntaxReferences.FirstOrDefault();
if (syntaxRef?.GetSyntax() is ParameterSyntax paramSyntax && paramSyntax.Default is not null)
Expand Down
Loading