Adapt HistoryTextWrapper#notifyListeners #3703
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the notifyListeners method in HistoryTextWrapper to call super#notifyListeners since not calling it changes the underlying default behaviour of its superclasses leading to faulty behavior, e.g. it breaks the chain of DPIChange processing leading to a broken drop down button in the HistoryTextWraper on DPIChange Event.
Bug Explained
When a file editor has the Ctrl+F search box open and the editor window is moved across screens with different DPI/scaling settings, the search box does not scale properly.
Steps to Reproduce:
Reason
The class
HistoryTextWrapperoverrides the methodnotifyListeners:This method doesn't call
super.notifyListeners(eventType, event), hence, the chain of DPIChange processing is broken, leading to the toolbar under theHistoryTextWrappernever scaling.