Console does not need to start UI job every second #2427
Merged
+11
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to update console status line, ProcessConsole.computeName() calls resetName() every second once console is created. This causes new UI job to be started every second via timerExec(), with code already being executed on UI thread. It is a misuse of Jobs framework, it makes use of jobs dispatching where no jobs are needed. The code can use Display.execute() for a more lightweight console status update. As a nice side effect no jobs are flashing in the Progress view every second (if system jobs are shown).
Contributor
Compiler warnings: 1) Varargs methods should only override or be overridden by other varargs methods unlike StringVariableSelectionDialog.setListElements(Object[]) and AbstractElementListSelectionDialog.setListElements(Object...) 2) Type IStringVariable[] of the last argument to method setListElements(Object...) doesn't exactly match the vararg parameter type. Cast to Object[] to confirm the non-varargs invocation, or pass individual arguments of type Object for a varargs invocation. Side effect of the signature change in org.eclipse.ui.dialogs.AbstractElementListSelectionDialog.setListElements(Object...) See eclipse-platform/eclipse.platform.ui@647256d / eclipse-platform/eclipse.platform.ui#3675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to update console status line, ProcessConsole.computeName() calls resetName() every second once console is created. This causes new UI job to be started every second via timerExec(), with code already being executed on UI thread. It is a misuse of Jobs framework, it makes use of jobs dispatching where no jobs are needed. The code can use Display.execute() for a more lightweight console status update.
As a nice side effect no jobs are flashing in the Progress view every second (if system jobs are shown).