-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(extractors): decouple extractors from common crate #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LNSD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this refactoring is to break the dependency on common, and the outcome should also add value in terms of organization.
Please check my comments. And check whether there are any other similar pieces of code that need to be moved into the "chain-specific" raw datasets modules.
As a rule of thumb:
- Specific to one extractor: keep it in the extractor crate.
- Common to different extractors (same chain technlogy, e.g., evm): Move it to
raw_datasets::evm::*. - Common to all extractors:
raw_datasets::<specific-module>::*(e.g., arrow helpers inraw_datasets::arrow::*). - Common to all datasets:
datasets_commoncrate.
7cc0713 to
fc1bb15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much better 😁
I have detected some minor issues. Can you check my comments?
9a4c7b2 to
9420000
Compare
9420000 to
f8f645b
Compare
LNSD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
* refactor(extractors): decouple extractors from common crate * refactor(datasets-raw): remove BoxError and BoxResult type aliases
Remove dependency on
commoncrate from all extractors (evm-rpc, firehose, solana)by moving shared types and utilities to
datasets-raw.Changes:
blocks.rs,logs.rs) fromcommontodatasets-rawarrow_helpers.rswith array builders todatasets-rawprovider.rsfromcommontoevm-rpcextractorBoxError,Bytes32,EvmAddress, etc.) todatasets-rawdatasets-rawinstead ofcommonCargo.toml