fix: avoid startup crash when V8 sandbox is disabled

[david-metrica]

Description of Change

This fixes startup crash in custom builds where V8 sandbox is disabled.

32-bit builds do not enable the V8 sandbox, so checking ARCH_CPU_32_BIT alongside !V8_ENABLE_SANDBOX is redundant.

For more information refer to:
#49199 (Issue where this was solved)
#48699 (Same problem but the issue was unresolved)

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

notes: Fixed startup crash when V8 sandbox is disabled.

[deepak1556]

Please follow the steps here to edit and re-export the existing patch https://github.com/electron/electron/blob/main/docs/development/patches.md#editing-an-existing-patch

[david-metrica]

Please follow the steps here to edit and re-export the existing patch https://github.com/electron/electron/blob/main/docs/development/patches.md#editing-an-existing-patch

Hello @deepak1556 ,

Sorry if this is a basic question, but I’m not entirely sure how this process works.

The instructions say:

Editing an existing patch
$ cd src/v8
$ vim some/code/file.cc

I assume this means I need to run gclient sync and then modify the same files that the existing patch touches. However, I’m unsure on how the tooling knows which specific patch I’m editing.

The instructions also mention:
“Find the commit SHA of the patch you want to edit.”

Which commit SHA is this referring to?

• The commit I originally created?
• The latest revision of the patch?
• Or the original commit where the patch was first introduced?

I apologise if this is obvious, I’m a bit lost on the workflow here.

Also, I’m currently in transit (flying from Asia to Europe), so I won’t be able to update this pull request until Friday.

Thanks in advance for your help.