-
-
Notifications
You must be signed in to change notification settings - Fork 112
Consistent search settings between document search and global search #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+81
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
reviewed
Oct 16, 2025
zeebok
reviewed
Oct 16, 2025
zeebok
approved these changes
Oct 16, 2025
Contributor
zeebok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to do the trick for reasons I don't entirely understand! I only have one optional change suggestion, otherwise this seems to be good to go
Use boolean Co-authored-by: Ryan Kornheisl <ryan@skarva.tech>
zeebok
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1277
For simplicity the global search dialog can no longer change search settings - this is only done in the searchbar. The global search dialog instead just informs the user of the current settings.
If required these settings could also be changed in the global search dialog and synchronised to the search bar.
Some other minor fixes/refinements in passing: