Skip to content

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 1, 2025

Fixes #1277

For simplicity the global search dialog can no longer change search settings - this is only done in the searchbar. The global search dialog instead just informs the user of the current settings.

If required these settings could also be changed in the global search dialog and synchronised to the search bar.

Some other minor fixes/refinements in passing:

  • Validate regex expressions in the global search dialog (but not in the searchbar currently)
  • Implement missing wholeword global searching
  • Implement "Mixed case" setting in global searching
  • Disable other settings when "Use Regex" is active.

@jeremypw jeremypw added this to the 8.1 milestone Jul 1, 2025
@jeremypw jeremypw modified the milestones: 8.1, 8.2 Jul 23, 2025
@jeremypw jeremypw marked this pull request as ready for review August 9, 2025 15:41
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to do the trick for reasons I don't entirely understand! I only have one optional change suggestion, otherwise this seems to be good to go

@zeebok zeebok merged commit f389216 into master Oct 16, 2025
6 checks passed
@zeebok zeebok deleted the jeremypw/consistent-case-sensitivity branch October 16, 2025 17:17
@jeremypw jeremypw modified the milestones: 8.2, 8.1.2 Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global Search case sensitivity behaviour differs from local search

3 participants