Cloning: Show progress in sidebar

[jeremypw]

Fixes #1628

During cloning the dialog hides and a spinner appears in the sidebar. On a successful clone a toast appears in the sidebar. If the clone is unsuccessful the behaviour is as before.

[jeremypw]

Note: The "Revert shortcut clash" commit was included in error and reverted. It belongs in #1640.

[jeremypw]

Just noticed the issue also mentioned sending a notification if the window is not focused. This PR does not implement that at present - it is targeted on the toast aspect.

[jeremypw]

Now implemented notification if not focused. Do we need to withdraw notification (like Terminal) if Code window becomes active?

It did not seem necessary to add an action to the notification - when clicked the sending app was focused anyway.

[zeebok]

Looks good to me, and functions as advertised. I can't speak to the styling, it feels odd to be right aligned but I don't know what would be better. I do hope to see a future PR for having a progress bar in the dock!

[jeremypw]

@zeebok Thanks for the review! I'll merge and hope that will stimulate further suggestions for appearance improvement. I'll look into progress indication in the new dock.

[teamcons]

Fixes #1628

During cloning the dialog hides and a spinner appears in the sidebar. On a successful clone a toast appears in the sidebar. If the clone is unsuccessful the behaviour is as before.

I cant test this, but from the screenshot and at a cursory glance through the code : The list of folders pads down to leave space for the toaster ?
You are not using an overlay so the toast can show up above the list ? Is there a specific reason?

[jeremypw]

You are not using an overlay so the toast can show up above the list ? Is there a specific reason?

Not that I can recall - I'll push a PR to use an overlay.