Fix blocking select/poll on pipes with ASYNCIFY. NFC #26206
Merged
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to actually test any of the stdout of this test so what was happening here is that after the timeout and the writing to the pipe, the node process was just existing with 0 exit code. Basically the JSPI/ASYNCIFY continuation of the program was never run and node simply exits because there was nothing left in the event loop.
sbc100
changed the title
sbc100
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to actually test any of the stdout of this test so what was happening here is that after the timeout and the writing to the pipe, the node process was just existing with 0 exit code. Basically the JSPI/ASYNCIFY continuation of the program was never run and node simply exits because there was nothing left in the event loop.