Skip to content

Comments

[EM_JS] Fix handling of void argument list with whitespace#26248

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom
inolen:inolen/em_js_whitespace
Feb 12, 2026
Merged

[EM_JS] Fix handling of void argument list with whitespace#26248
sbc100 merged 1 commit intoemscripten-core:mainfrom
inolen:inolen/em_js_whitespace

Conversation

@inolen
Copy link
Collaborator

@inolen inolen commented Feb 12, 2026

No description provided.

@inolen inolen force-pushed the inolen/em_js_whitespace branch from 92f6c49 to 475f3e7 Compare February 12, 2026 00:32
@sbc100 sbc100 changed the title em_js / fix handling of functions which explicitly declare a void arg… [EM_JS] Fix handling of functions which explicitly declare a void arg… Feb 12, 2026
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbc100 sbc100 changed the title [EM_JS] Fix handling of functions which explicitly declare a void arg… [EM_JS] Fix handling of functions which explicitly declare a void argument list with whitespace between enclosing parenthesis Feb 12, 2026
@sbc100 sbc100 changed the title [EM_JS] Fix handling of functions which explicitly declare a void argument list with whitespace between enclosing parenthesis [EM_JS] Fix handling of void argument list with whitespace Feb 12, 2026
@sbc100
Copy link
Collaborator

sbc100 commented Feb 12, 2026

Strange, the wasm2js1 errors look real.

…ument list with whitespace between enclosing parenthesis
@inolen inolen force-pushed the inolen/em_js_whitespace branch from 475f3e7 to f612fe0 Compare February 12, 2026 12:39
@inolen
Copy link
Collaborator Author

inolen commented Feb 12, 2026

There was some code above that doing similar logic that also needed to call strip - I synchronized the two code blocks.

@sbc100 sbc100 merged commit e998496 into emscripten-core:main Feb 12, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants