Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpx/_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def __init__(
extensions: RequestExtensions | None = None,
) -> None:
self.method = method.upper()
self.url = URL(url) if params is None else URL(url, params=params)
self.url = URL(url) if params is None else URL(url).copy_merge_params(params)
self.headers = Headers(headers)
self.extensions = {} if extensions is None else dict(extensions)

Expand Down
12 changes: 10 additions & 2 deletions tests/models/test_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,18 @@ def test_request_params():
request = httpx.Request("GET", "http://example.com", params={})
assert str(request.url) == "http://example.com"

# Params are merged with existing URL query parameters, not replaced.
request = httpx.Request(
"GET", "http://example.com?c=3", params={"a": "1", "b": "2"}
)
assert str(request.url) == "http://example.com?a=1&b=2"
assert str(request.url) == "http://example.com?c=3&a=1&b=2"

# Empty params preserves existing URL query parameters.
request = httpx.Request("GET", "http://example.com?a=1", params={})
assert str(request.url) == "http://example.com"
assert str(request.url) == "http://example.com?a=1"

# Params with overlapping keys override existing URL query parameters.
request = httpx.Request(
"GET", "http://example.com?a=1&b=2", params={"b": "3", "c": "4"}
)
assert str(request.url) == "http://example.com?a=1&b=3&c=4"