Use immutable dates? #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace nesbot/carbon with cakephp/chronos
Contributor
|
Not entirely sure we need/want to do this anymore. @equip/contributors ? |
|
@shadowhand I think using Chronos instead of Carbon seems like a good idea, given Equip's focus on immutability. But are you more wondering if we want this |
Contributor
|
@bvisness mostly I am unsure what, if any, impact this would have in terms of versioning. Seems likely this would be a major version change? |
|
@shadowhand I suppose it probably would be, since we might have equip/data users who expect dates to be mutable. Maybe this goes on the back burner for a while? |
Contributor
|
Created a 3.x milestone and moved it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an emphasis on immutability/vo like things here, so maybe using immutable datetime objects makes sense?
Maybe I'm wrong. Just an idea.