Preventing pushing the current node's URL to its networkNodes.#8
Open
ahmedalmaliki wants to merge 1 commit intoerictraub:masterfrom
Open
Preventing pushing the current node's URL to its networkNodes.#8ahmedalmaliki wants to merge 1 commit intoerictraub:masterfrom
ahmedalmaliki wants to merge 1 commit intoerictraub:masterfrom
Conversation
When you post a newNodeUrl to the node with the same URL it gets saved with the rest of the network URLS, for example: if you post http://localhost:3000 to http://localhost:3001/register-and-brodcast-node, you will have the URL in the networkNodes despite its being the same URL for that node. my change prevents that and it makes sure you can not post a node's URL to its self.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you post a newNodeUrl to the node with the same URL it gets saved with the rest of the network URLS, for example:
if you post http://localhost:3000 to http://localhost:3000/register-and-brodcast-node, you will have the URL in the networkNodes despite its being the same URL for that node.
my change prevents that and it makes sure you can not post a node's URL to its self.