Skip to content

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jan 28, 2026

Summary by CodeRabbit

  • Chores
    • Updated security advisory configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Updated deny.toml to add a new ignored advisory "RUSTSEC-2025-0141" to the advisories ignore list with an inline comment.

Changes

Cohort / File(s) Summary
Configuration Updates
deny.toml
Added ignored advisory "RUSTSEC-2025-0141" with comment to the advisories ignore list; previously empty.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A new advisory joins the roster so fine,
In deny.toml, it's marked "don't mind,"
RUSTSEC-2025-0141 we shall ignore,
With a little comment, we've settled the score! 🔒

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix cargo deny CI check' is directly related to the changeset which updates deny.toml to add an ignored advisory, fixing the cargo deny check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

📊 iai-callgrind Benchmark Results

⚠️ 1 Regression(s) Detected

| Benchmark | Base | PR | Change | % |
|-----------|------|----|---------|
| iai_algos::corner_to_corner_idastar | 193,802 | 194,733 | +931 | +0.48% |

➡️ 19 Unchanged (within ±0.1%)

Click to expand
Benchmark Instructions
iai_algos::corner_to_corner_astar 163,252
iai_algos::corner_to_corner_bfs 2,947,632
iai_algos::corner_to_corner_bfs_bidirectional 3,897,954
iai_algos::corner_to_corner_dfs 3,577,719
iai_algos::corner_to_corner_dijkstra 3,165,305
iai_algos::corner_to_corner_fringe 216,764
iai_algos::corner_to_corner_iddfs 3,718,131
iai_algos::no_path_astar 3,927,201
iai_algos::no_path_bfs 2,756,515
iai_algos::no_path_bfs_bidirectional 3,442,346
iai_algos::no_path_dfs 3,615,384
iai_algos::no_path_dijkstra 3,089,064
iai_algos::no_path_fringe 4,417,030
iai_edmondskarp::wikipedia_example_dense 38,095
iai_edmondskarp::wikipedia_example_sparse 65,600
iai_kuhn_munkres::kuhn_munkres_size_128 6,400,113
iai_kuhn_munkres::kuhn_munkres_size_32 363,151
iai_kuhn_munkres::kuhn_munkres_size_64 1,791,095
iai_separate_components::bench_separate_components 16,594,841

iai-callgrind measures instructions executed, which is deterministic and not affected by system load.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

Merging this PR will degrade performance by 14.86%

⚡ 3 improved benchmarks
❌ 4 regressed benchmarks
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
no_path_astar 1.8 ms 1.5 ms +16.96%
fill-no_path_bfs 1.3 ms 1.5 ms -12.19%
fill-no_path_dijkstra 1.1 ms 1.3 ms -13.97%
fill-no_path_fringe 1.1 ms 1.3 ms -14.86%
no_path_dijkstra 1.7 ms 1.4 ms +17.67%
fill-corner_to_corner_dijkstra 1.4 ms 1.5 ms -12.09%
corner_to_corner_dijkstra 1.7 ms 1.5 ms +15.98%

Comparing push-vqytnmropqzw (a9a04ca) with main (707ce3a)

Open in CodSpeed

@samueltardieu
Copy link
Member Author

Superseded by #750

auto-merge was automatically disabled January 28, 2026 15:52

Pull request was closed

@samueltardieu samueltardieu deleted the push-vqytnmropqzw branch January 28, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants