Improve branch filtering and raise error on empty dataframes #162
+67
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
commented
Dec 26, 2025
Comment on lines
+44
to
+57
| ## Filter pull requests by branch | ||
|
|
||
| Many repositories work with multiple active branches (e.g., `main`, `develop`, feature branches). When generating a changelog for a specific release, you typically only want to include pull requests that were merged into the release branch. | ||
|
|
||
| Use the `--branch` (or `-b`) parameter to filter pull requests by their target branch: | ||
|
|
||
| ```bash | ||
| github-activity org/repo --since v1.0.0 --until v2.0.0 --branch main | ||
| ``` | ||
|
|
||
| This will **only include pull requests that targeted the `main` branch**, excluding any PRs merged to other branches like `develop` or feature branches. | ||
|
|
||
| ```{note} | ||
| You can use any git reference (tag, commit hash, etc.) in place of a branch name. |
Member
Author
There was a problem hiding this comment.
This is just documenting pre-existing functionality
choldgraf
commented
Dec 26, 2025
Comment on lines
+228
to
+231
| # Wrap in a try/except so we don't have an ugly stack trace if there's an error | ||
| try: | ||
| if args.all: | ||
| md = generate_all_activity_md(args.target, **common_kwargs) |
Member
Author
There was a problem hiding this comment.
This is all just tab-adding. The only difference is the try/except statement, so that if valueerrors happen down below we can display them nicely.
choldgraf
commented
Dec 26, 2025
choldgraf
commented
Dec 26, 2025
Member
Author
|
I gave this a quick review just to sanity check - it seems OK to me and it makes our tests happy, so I'll merge this and cut a quick release since this fixes our tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things I noticed in #161
None)maindue to queries that return an empty result #161