Conditionally add toggle sidebar button#925
Open
max-marped wants to merge 1 commit intoexecutablebooks:masterfrom
Open
Conditionally add toggle sidebar button#925max-marped wants to merge 1 commit intoexecutablebooks:masterfrom
max-marped wants to merge 1 commit intoexecutablebooks:masterfrom
Conversation
max-marped
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the
sidebar-toggle primary-togglebutton is shown even though there is no sidebar to show. If you for example configure a page to not have a sidebar using thehtml_sidebarssetting as described in the docs.The condition matches how pydata-sphinx-theme does it for rendering the sidebar elements in sidebar-primary.html.
Cheers!
Solves: #924