Skip to content

Conversation

@jserv
Copy link
Member

@jserv jserv commented Jan 31, 2026

This replaces two-step configuration process with direct application selection. Users now choose exactly one option: Test Suite, Pingpong Demo, or kernel-only build.

Hardware test menu now depends directly on user application selection, hiding hardware tests when USER_APP_NONE is selected.


Summary by cubic

Simplifies configuration by replacing the two-step app setup with a single “User Application” choice: Test Suite, Pingpong Demo, or None. Improves build reliability by auto-regenerating autoconf.h when .config changes.

  • Refactors

    • Introduced choice: USER_APP_TESTS, USER_APP_PINGPONG, USER_APP_NONE.
    • Consolidated user/Kconfig; removed user/Kconfig.apps and user/Kconfig.tests.
    • Hardware tests moved under “Hardware Test Cases” and kept EXTI IRQ deps.
    • Build system: added PYTHON variable (default python3); Kconfig tools use $(PYTHON).
    • autoconf.h now regenerates on config changes and is a dependency for all objects; failures clean partial files.
  • Migration

    • Update defconfigs: CONFIG_TESTS → CONFIG_USER_APP_TESTS; CONFIG_PINGPONG → CONFIG_USER_APP_PINGPONG; set CONFIG_USER_APP_NONE=y for kernel-only.
    • Remove CONFIG_BUILD_USER_APPS and run make oldconfig/menuconfig.
    • Find hardware tests under “Hardware Test Cases” in user/Kconfig.

Written for commit b9e7ed9. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="user/Kconfig">

<violation number="1" location="user/Kconfig:42">
P2: Misleading comment: the menu is NOT independent of main application choice. It explicitly depends on `USER_APP_TESTS || USER_APP_PINGPONG`, so it will be hidden when `USER_APP_NONE` is selected. Consider rewording to accurately describe the dependency.</violation>

<violation number="2" location="user/Kconfig:51">
P2: Misleading help text: LCD_TEST is NOT independent of main user application selection. It inherits the menu's `depends on USER_APP_TESTS || USER_APP_PINGPONG` dependency. Consider removing or correcting this statement.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

This replaces two-step configuration process with direct application
selection. Users now choose exactly one option: Test Suite, Pingpong
Demo, or kernel-only build.

Both hardware tests are only available when USER_APP_TESTS or
USER_APP_PINGPONG is selected, and hidden when USER_APP_NONE is chosen.
@jserv jserv merged commit 8e6a823 into master Jan 31, 2026
6 checks passed
@jserv jserv deleted the refine-configure branch January 31, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants