Skip to content

Conversation

@rolandnagy
Copy link

@rolandnagy rolandnagy commented Jan 16, 2026

Summary:

Fixed an issue where developers with identical development environments get different checksums for hermes-engine in Podfile.lock, causing unnecessary git conflicts.

The root cause was that hermes-engine.podspec used require.resolve() to get the absolute path to hermes-compiler, which included usernames. This caused the generated hermes-engine.podspec.json to differ across developers, resulting in different checksums.

See Issue: #54891

Changelog:

[IOS] [FIXED] - Fix hermes-engine Podfile.lock checksum inconsistency across developers

Test Plan:

  • Created a test project with local React Native changes
  • Ran pod install and verified hermes-engine.podspec.json contains
    ${PODS_ROOT}/../../node_modules/hermes-compiler path
  • Verified app builds and runs successfully with Hermes enabled
  • Confirmed hermesc binary resolves correctly at build time

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 16, 2026
@cortinico cortinico requested a review from cipolleschi January 16, 2026 16:49
@meta-codesync
Copy link

meta-codesync bot commented Jan 18, 2026

@philIip has imported this pull request. If you are a Meta employee, you can view this in D90932424.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants