Add multi-session support to Device.js #55237
Open
+2,268
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#55055 TSIA. Changelog: [Internal] Differential Revision: D90174644 Reviewed By: robhogan
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Differential Revision: D90174645 Reviewed By: robhogan
Summary: Implements multi-debugger support in the C++ InspectorPackagerConnection class. This allows multiple debugger sessions to connect to the same page simultaneously via session IDs. Key changes: - Change session storage from pageId -> Session to pageId -> (sessionId -> Session) nested map - Parse and include sessionId in connect/disconnect/wrappedEvent message handling - Report supportsMultipleDebuggers: true capability in page listings - Maintain backwards compatibility with legacy proxies that don't send sessionId - Add new test file for multi-session scenarios - Update protocol documentation for multi-debugger support Differential Revision: D90174642
Summary: Adds multi-session support to the Node side of the inspector-proxy protocol implementation. The protocol now has an explicit `sessionId` property in all relevant messages. Multi-session support is fully backwards compatible: * An app that does not report itself as multi-session capable will get the old proxy behaviour. * If the `enableStandaloneFuseboxShell` experiment flag is disabled by the integrator/framework, we automatically disable multi-session support, too. This is to guarantee that we continue to have at most one active RNDT window/tab open per app. (The standalone shell guarantees this independently of the proxy, while the old browser-based flow requires the proxy to keep enforcing the single-session UX.) Changelog: [General][Added] Support multiple CDP connections to one React Native Host (diff 2 of 2) Differential Revision: D90174643
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds multi-session support to the Node side of the inspector-proxy protocol implementation. The protocol now has an explicit
sessionIdproperty in all relevant messages.Multi-session support is fully backwards compatible:
enableStandaloneFuseboxShellexperiment flag is disabled by the integrator/framework, we automatically disable multi-session support, too. This is to guarantee that we continue to have at most one active RNDT window/tab open per app. (The standalone shell guarantees this independently of the proxy, while the old browser-based flow requires the proxy to keep enforcing the single-session UX.)Changelog: [General][Added] Support multiple CDP connections to one React Native Host (diff 2 of 2)
Differential Revision: D90174643