Add missing mutex lock to NetworkHandler::disable() #55241
+2,269
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#55055 TSIA. Changelog: [Internal] Differential Revision: D90174644 Reviewed By: robhogan
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Differential Revision: D90174645 Reviewed By: robhogan
Summary: Implements multi-debugger support in the C++ InspectorPackagerConnection class. This allows multiple debugger sessions to connect to the same page simultaneously via session IDs. Key changes: - Change session storage from pageId -> Session to pageId -> (sessionId -> Session) nested map - Parse and include sessionId in connect/disconnect/wrappedEvent message handling - Report supportsMultipleDebuggers: true capability in page listings - Maintain backwards compatibility with legacy proxies that don't send sessionId - Add new test file for multi-session scenarios - Update protocol documentation for multi-debugger support Differential Revision: D90174642
Summary: Implements multi-debugger support in the Node.js inspector-proxy Device class. This complements the C++ InspectorPackagerConnection changes and enables multiple debugger sessions to connect to the same page simultaneously via session IDs. Key changes: - Replace single #debuggerConnection with Map-based #debuggerConnections keyed by sessionId - Add #nextSessionId counter for generating unique session IDs - Add #deviceSupportsMultipleDebuggers flag (default false for backwards compatibility) - Update handleDebuggerConnection() to generate and use session IDs - Update message routing to include sessionId in connect/disconnect/wrappedEvent - Update test assertions to expect sessionId in message payloads - Maintain backwards compatibility with legacy devices that do not send sessionId Differential Revision: D90174643
Summary: TSIA Differential Revision: D90998980
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: TSIA
Differential Revision: D90998980