Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
Original file line number Diff line number Diff line change
Expand Up @@ -3544,40 +3544,48 @@ export function updateFragmentInstanceFiber(
}

export function commitNewChildToFragmentInstance(
childInstance: InstanceWithFragmentHandles,
childInstance: InstanceWithFragmentHandles | Text,
fragmentInstance: FragmentInstanceType,
): void {
if (childInstance.nodeType === TEXT_NODE) {
return;
}
const instance: InstanceWithFragmentHandles = (childInstance: any);
const eventListeners = fragmentInstance._eventListeners;
if (eventListeners !== null) {
for (let i = 0; i < eventListeners.length; i++) {
const {type, listener, optionsOrUseCapture} = eventListeners[i];
childInstance.addEventListener(type, listener, optionsOrUseCapture);
instance.addEventListener(type, listener, optionsOrUseCapture);
}
}
if (fragmentInstance._observers !== null) {
fragmentInstance._observers.forEach(observer => {
observer.observe(childInstance);
observer.observe(instance);
});
}
if (enableFragmentRefsInstanceHandles) {
addFragmentHandleToInstance(childInstance, fragmentInstance);
addFragmentHandleToInstance(instance, fragmentInstance);
}
}

export function deleteChildFromFragmentInstance(
childInstance: InstanceWithFragmentHandles,
childInstance: InstanceWithFragmentHandles | Text,
fragmentInstance: FragmentInstanceType,
): void {
if (childInstance.nodeType === TEXT_NODE) {
return;
}
const instance: InstanceWithFragmentHandles = (childInstance: any);
const eventListeners = fragmentInstance._eventListeners;
if (eventListeners !== null) {
for (let i = 0; i < eventListeners.length; i++) {
const {type, listener, optionsOrUseCapture} = eventListeners[i];
childInstance.removeEventListener(type, listener, optionsOrUseCapture);
instance.removeEventListener(type, listener, optionsOrUseCapture);
}
}
if (enableFragmentRefsInstanceHandles) {
if (childInstance.unstable_reactFragments != null) {
childInstance.unstable_reactFragments.delete(fragmentInstance);
if (instance.unstable_reactFragments != null) {
instance.unstable_reactFragments.delete(fragmentInstance);
}
}
}
Expand Down
23 changes: 18 additions & 5 deletions packages/react-native-renderer/src/ReactFiberConfigFabric.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ import {
type PublicTextInstance,
type PublicRootInstance,
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
import {enableFragmentRefsInstanceHandles} from 'shared/ReactFeatureFlags';
import {
enableFragmentRefsInstanceHandles,
enableFragmentRefsTextNodes,
} from 'shared/ReactFeatureFlags';

const {
createNode,
Expand Down Expand Up @@ -847,10 +850,15 @@ export function updateFragmentInstanceFiber(
}

export function commitNewChildToFragmentInstance(
childInstance: Instance,
childInstance: Instance | TextInstance,
fragmentInstance: FragmentInstanceType,
): void {
const publicInstance = getPublicInstance(childInstance);
// Text nodes are not observable
if (enableFragmentRefsTextNodes && childInstance.canonical == null) {
return;
}
const instance: Instance = (childInstance: any);
const publicInstance = getPublicInstance(instance);
if (fragmentInstance._observers !== null) {
if (publicInstance == null) {
throw new Error('Expected to find a host node. This is a bug in React.');
Expand All @@ -869,11 +877,16 @@ export function commitNewChildToFragmentInstance(
}

export function deleteChildFromFragmentInstance(
childInstance: Instance,
childInstance: Instance | TextInstance,
fragmentInstance: FragmentInstanceType,
): void {
// Text nodes are not observable
if (enableFragmentRefsTextNodes && childInstance.canonical == null) {
return;
}
const instance: Instance = (childInstance: any);
const publicInstance = ((getPublicInstance(
childInstance,
instance,
): any): PublicInstanceWithFragmentHandles);
if (enableFragmentRefsInstanceHandles) {
if (publicInstance.unstable_reactFragments != null) {
Expand Down
8 changes: 6 additions & 2 deletions packages/react-reconciler/src/ReactFiberCommitHostEffects.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ import {captureCommitPhaseError} from './ReactFiberWorkLoop';
import {trackHostMutation} from './ReactFiberMutationTracking';

import {runWithFiberInDEV} from './ReactCurrentFiber';
import {enableFragmentRefs} from 'shared/ReactFeatureFlags';
import {
enableFragmentRefs,
enableFragmentRefsTextNodes,
} from 'shared/ReactFeatureFlags';

export function commitHostMount(finishedWork: Fiber) {
const type = finishedWork.type;
Expand Down Expand Up @@ -258,7 +261,8 @@ export function commitNewChildToFragmentInstances(
parentFragmentInstances: null | Array<FragmentInstanceType>,
): void {
if (
fiber.tag !== HostComponent ||
(fiber.tag !== HostComponent &&
!(enableFragmentRefsTextNodes && fiber.tag === HostText)) ||
// Only run fragment insertion effects for initial insertions
fiber.alternate !== null ||
parentFragmentInstances === null
Expand Down
13 changes: 11 additions & 2 deletions packages/react-reconciler/src/ReactFiberCommitWork.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import {
enableFragmentRefs,
enableEagerAlternateStateNodeCleanup,
enableDefaultTransitionIndicator,
enableFragmentRefsTextNodes,
} from 'shared/ReactFeatureFlags';
import {
FunctionComponent,
Expand Down Expand Up @@ -1532,7 +1533,11 @@ function commitDeletionEffectsOnFiber(
if (!offscreenSubtreeWasHidden) {
safelyDetachRef(deletedFiber, nearestMountedAncestor);
}
if (enableFragmentRefs && deletedFiber.tag === HostComponent) {
if (
enableFragmentRefs &&
(deletedFiber.tag === HostComponent ||
(enableFragmentRefsTextNodes && deletedFiber.tag === HostText))
) {
commitFragmentInstanceDeletionEffects(deletedFiber);
}
// Intentional fallthrough to next branch
Expand Down Expand Up @@ -3009,7 +3014,11 @@ export function disappearLayoutEffects(finishedWork: Fiber) {
// TODO (Offscreen) Check: flags & RefStatic
safelyDetachRef(finishedWork, finishedWork.return);

if (enableFragmentRefs && finishedWork.tag === HostComponent) {
if (
enableFragmentRefs &&
(finishedWork.tag === HostComponent ||
(enableFragmentRefsTextNodes && finishedWork.tag === HostText))
) {
commitFragmentInstanceDeletionEffects(finishedWork);
}

Expand Down
Loading