[flags] make enableTrustedTypesIntegration dynamic
#35646
+93
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the dynamic fork to VARIANT to ensure all tests exercise that code path and enables the integration in experimental releases.
rickhanlonii
requested changes
Jan 28, 2026
Member
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
To roll this out I need to test it at meta, so we're not ready to enable this in experimental yet.
Author
|
Would it be worth to land the VARIANT change without the experimental upgrade? If so, happy to split that out. |
packages/react-dom/src/client/__tests__/trustedTypes-test.internal.js
Outdated
Show resolved
Hide resolved
Member
|
@hybrist yeah, i pushed to this branch to switch to We can merge this and I'll test it. If all goes well, this can probably go to experimental soonish, and could land in a minor. |
rickhanlonii
approved these changes
Jan 28, 2026
rickhanlonii
changed the title
enableTrustedTypesIntegration dynamic
Author
|
Thanks for the help getting this into shape! Sorry, could've caught the flag testing pattern myself. :) |
|
Comparing: 8c34556...a84f095 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the dynamic fork to VARIANT to ensure all tests exercise the
enableTrustedTypesIntegrationcode path and enable the integration (e.g. dropping the forced stringification) in experimental releases.Historically, the main issue was an old jsdom version and IE9 from what I can tell.
Summary
It looks like this was kind of meant to become a default while back (see #27859) and I don't see any clear signal on why it didn't. So this PR is asking the question... maybe it should just happen now?
How did you test this change?
Existing tests are passing with this change. It looks like this also might have already been tested internally at Facebook (?).