Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 28, 2026

Stacked on #35648

The en dash is used for number ranges or connections.

This seems not suitable for a diff. Our hydration diffs also use a minus symbol instead of en dash for removed lines. git-diff also uses minus.

@meta-cla meta-cla bot added the CLA Signed label Jan 28, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 28, 2026
@react-sizebot
Copy link

react-sizebot commented Jan 28, 2026

Comparing: ff191f2...ba15313

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.67 kB 608.67 kB = 107.63 kB 107.63 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.60 kB 674.60 kB = 118.58 kB 118.58 kB
facebook-www/ReactDOM-prod.classic.js = 693.92 kB 693.92 kB = 121.98 kB 121.98 kB
facebook-www/ReactDOM-prod.modern.js = 684.31 kB 684.31 kB = 120.37 kB 120.37 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ba15313

@eps1lon eps1lon requested a review from hoxyq January 28, 2026 10:15
@eps1lon eps1lon marked this pull request as ready for review January 28, 2026 10:15
@eps1lon eps1lon force-pushed the sebbie/01-28-_perf_tracks_use_minus_-_instead_of_en_dash_for_removed_props branch from ee15bb0 to ba15313 Compare January 28, 2026 11:02
@eps1lon eps1lon merged commit 87ae75b into facebook:main Jan 28, 2026
234 checks passed
@eps1lon eps1lon deleted the sebbie/01-28-_perf_tracks_use_minus_-_instead_of_en_dash_for_removed_props branch January 28, 2026 11:15
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants