Majordomo compatibility improvements #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vector of string/string_view were missing from the allowed types, only allowing bare c-style arrays of strings. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
force-pushed
the
majordomoFixes
branch
from
ff08f14 to
90321dc
Compare
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
The repository for the action has moved and it now uses compile_commands.json by default. Also bump the other action versions to the current versions. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
force-pushed
the
majordomoFixes
branch
from
90321dc to
cad3cee
Compare
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor inconsistency by adding
vector<string>which looks like it was an oversight that it wasn't defined.It also fixes the CI workflow which was using a sonarcloud github action which does not exist anymore. I've updated the workflow, but there is still some issue with the sonarcloud integration, but this could also be fixed separately i guess.
Originally this PR had some more changes, which where ultimately then fixed more consistently on the java side.