Skip to content

Conversation

@wirew0rm
Copy link
Member

IoSerialiser/Annotations: add quantitiy

Add an additional quantity field to the binary serialiser metadata.
This has to be followed up in opencmw-java so that the serialised metadata fields are identical.

Add cross compatibility test binary

Adds a small binary which can be used to crosstest other implementation
against this cpp implementation.
This is uploaded in the github action run, such that other
implementations can fetch and test against this binary in their CI.

Since this is a breaking serialisation format change, it should only be merged once the corresponding java changes and tests are completed.

Add an additional quantity field to the binary serialiser metadata.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage December 19, 2025 18:26 — with GitHub Actions Inactive
@wirew0rm wirew0rm marked this pull request as ready for review January 5, 2026 16:28
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 6, 2026 10:14 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
22.1% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Adds a small binary which can be used to crosstest other implementation
against this cpp implementation.
This is uploaded in the github action run, such that other
implementations can fetch and test against this binary in their CI.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm wirew0rm temporarily deployed to configure coverage January 7, 2026 14:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm had a problem deploying to configure coverage January 7, 2026 14:18 — with GitHub Actions Failure
@wirew0rm wirew0rm temporarily deployed to configure coverage January 7, 2026 14:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 7, 2026 14:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm deployed to configure coverage January 7, 2026 14:18 — with GitHub Actions Active
@wirew0rm wirew0rm temporarily deployed to configure coverage January 7, 2026 14:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants