Remove deprecated generators (Faker::Twitter and Faker::BossaNova) #3190
+247
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdaraujo
reviewed
Jan 19, 2026
| @@ -1,218 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module Faker | |||
Contributor
There was a problem hiding this comment.
should the file name change too?
lib/faker/default/twitter.rb
Contributor
Author
There was a problem hiding this comment.
oh yes, good catch 🦅 Thank you! Renamed it in 017fba3
thdaraujo
reviewed
Jan 19, 2026
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
Makes sense to me. Will this be published in a minor release?
thdaraujo
approved these changes
Jan 19, 2026
Please use Faker::X from now on. And note that the generator has been updated to match the new API response.
Please use Faker::Music::BossaNova.
stefannibrasil
force-pushed
the
sb-remove-deprecated-generators-3189
branch
from
379ed52 to
017fba3
Compare
Contributor
Author
Yes, minor is what I am thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faker::Twitter->Faker::X. Some methods got deprecated as well.Faker::BossaNova->Faker::Music::BossaNovaCloses #3189