Skip to content

👷 Run mypy by pre-commit #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 6 commits into from
Feb 3, 2026
Merged

👷 Run mypy by pre-commit #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27fa24c
Run mypy by pre-commit
YuriiMotov Feb 2, 2026
0ba15ce
Trigger mypy check
YuriiMotov Feb 3, 2026
44ee4e9
Install dependencies with `--extra standard` in `pre-commit.yml`
YuriiMotov Feb 3, 2026
93ada57
Address mypy warning
YuriiMotov Feb 3, 2026
6ccfdf1
Revert "Trigger mypy check"
YuriiMotov Feb 3, 2026
77e4067
Remove `types: [python]` from mypy hook in `pre-commit.yaml`
YuriiMotov Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
pyproject.toml
uv.lock
- name: Install Dependencies
run: uv sync --locked
run: uv sync --locked --extra standard
- name: Run prek - pre-commit
id: precommit
run: uvx prek run --from-ref origin/${GITHUB_BASE_REF} --to-ref HEAD --show-diff-on-failure
Expand Down
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,10 @@ repos:
require_serial: true
language: unsupported
types: [python]

- id: local-mypy
name: mypy check
entry: uv run mypy src tests
require_serial: true
language: unsupported
pass_filenames: false
3 changes: 2 additions & 1 deletion tests/test_utils_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
from logging.config import dictConfig

from pytest import LogCaptureFixture

Expand Down Expand Up @@ -63,7 +64,7 @@ def test_log_config_does_not_disable_existing_loggers(
logger1.setLevel(logging.INFO)
logger1.info("Message before configuration")

logging.config.dictConfig(get_uvicorn_log_config())
dictConfig(get_uvicorn_log_config())

logger2 = logging.getLogger(__name__)

Expand Down