✨ Add support for Literal types #1736
Open
+210
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconstructing PR #1439, as the original author has closed this PR but @YuriiMotov and I had actually spent quite a bit of time on this already (in fact, we had completely rewritten the PR at this point 🙈).
Let me recap the history:
Literaltype annotation with SQLModel.Literalvalues were strings (thus creating a DB column with type string), which @tiangolo pointed out wouldn't be ideal because it would be unexpected for input likeLiteral[1, 2, 3].intand all-boolcases, to at least set the DB column type correctly. But he also raised the question of data validation.Literal. This way, the data can't get corrupted and the user won't receive values that don't match the expectedLiteraldefinition.stras "best attempt", (2) reject the input entirely or (3) some other way I'm not seeing.