Also use faust rebalance protocol when using static parition assignment#658
Open
Peter200lx wants to merge 1 commit intofaust-streaming:masterfrom
Open
Also use faust rebalance protocol when using static parition assignment#658Peter200lx wants to merge 1 commit intofaust-streaming:masterfrom
Peter200lx wants to merge 1 commit intofaust-streaming:masterfrom
Conversation
wbarnha
reviewed
Jul 11, 2025
Member
wbarnha
left a comment
There was a problem hiding this comment.
This is definitely a good idea, but it would give me peace of mind knowing that there is a test checking that this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2022 Faust added a fallback to Round Robin w/ PR #402 when
table_standby_replicaswasn't used. In 2024 Faust added support for KIP-345 kafka static-partition-assignment #600. When a user is specifying static partition assignment, using Round Robin doesn't respect the static partition instance IDs. This re-adds use of the Faust assigner when static partition assignment is configured, and brings it in line with comment onconsumer_group_instance_id:https://github.com/faust-streaming/faust/blob/master/faust/types/settings/settings.py#L1113-L1116
Also the variable defaults to
None, thus the truthiness check being a simple way of testing if it has been set:https://github.com/faust-streaming/faust/blob/master/faust/types/settings/settings.py#L113