Update to Deno 2.7.1 and remove unconditional Temporal unstable requirements#588
Update to Deno 2.7.1 and remove unconditional Temporal unstable requirements#588dahlia merged 2 commits intofedify-dev:mainfrom
Conversation
Bumped the pinned Deno version to 2.7.1 in mise and the shared GitHub Actions setup. Removed unconditional --unstable-temporal usage from root check tasks and configuration now that Temporal is stable in Deno 2.7. Updated fedify init's Deno config generation so temporal is added to unstable only on Deno versions earlier than 2.7.0, and omitted when no unstable flags are required. Refreshed installation and tutorial documentation to remove --unstable-temporal from default commands and clarify the compatibility note for Deno versions below 2.7.0. Added a changelog entry describing the runtime bump and Temporal compatibility updates. Co-Authored-By: Codex <codex@openai.com>
Summary of ChangesHello @dahlia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Deno environment by upgrading to version 2.7.1 and adapting to the stabilization of the Temporal API. The changes streamline configurations by removing unnecessary unstable flags and introduce intelligent version-aware handling for the Temporal API in project initialization, ensuring compatibility across different Deno versions while leveraging the latest stable features. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates Deno to version 2.7.1 and removes the now-unnecessary --unstable-temporal flag. The changes are consistent across configuration, documentation, and CI files. A key improvement is the new logic in @fedify/init to conditionally add the unstable flag based on the detected Deno version, ensuring backward compatibility. The implementation is robust, but I have one suggestion to improve debuggability in the version detection logic.
Add debug logging in the Deno version fallback path for fedify init so errors from `deno --version` are no longer silently swallowed. The existing `null` fallback behavior remains unchanged, but unexpected runtime or permission issues are now diagnosable during troubleshooting. fedify-dev#588 (comment) Co-Authored-By: Codex <codex@openai.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
This PR updates the repository to use Deno 2.7.1 and removes unconditional
Temporalunstable-flag requirements where they are no longer needed.2.7.1inmise.toml2.7.1--unstable-temporalfrom root check tasks/configunstable.temporalusage@fedify/initgeneration logic:"temporal"tounstableonly when installed Deno is< 2.7.0unstablefield when no unstable features are required--unstable-temporal< 2.7.0still needs--unstable-temporalorunstable.temporalWhy
Since the Temporal API is stabilized in Deno 2.7, the previous unconditional unstable Temporal configuration is no longer necessary on modern Deno versions.
Validation
mise run check:typespasseddeno check packages/init/src/action/configs.tspassedNotes
This keeps backward compatibility for users on Deno versions earlier than 2.7.0 through conditional handling in
fedify init.