support nested any-of to use with openapi v3.1 type null#1683
Open
smarlhens wants to merge 1 commit intoferdikoomen:mainfrom
Open
support nested any-of to use with openapi v3.1 type null#1683smarlhens wants to merge 1 commit intoferdikoomen:mainfrom
smarlhens wants to merge 1 commit intoferdikoomen:mainfrom
Conversation
|
I have a nested The generated api code seems to ignore the AnyOf, and generates the type as: instead of: does this PR also fix this issue? |
Author
|
hey @PaulVrugt, with this PR changes, it will generate: export type SomeDto = {
value?: (number | string | Array<(string | number)>) | null;
};you can check on your machine if you want: git clone git@github.com:smarlhens/openapi-typescript-codegen.git
git checkout feat/support-nested-any-of
npm installthen add at the end of "SomeDto": {
"type": "object",
"properties": {
"value": {
"oneOf": [
{
"type": "integer",
"format": "int32"
},
{
"type": "string"
},
{
"type": "array",
"items": {
"anyOf": [
{
"type": "string"
},
{
"type": "number"
}
]
}
}
],
"nullable": true
}
}
}and then run npm run test:update
git diffyou will see that inside |
|
Hi @smarlhens , so the short answer is |
|
@ferdikoomen can we get this merged? We are running into this in our code |
Author
Yes 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋🏻
Thanks @ferdikoomen for your amazing job on this library 🙏🏻
I've tried my best to implement support for nested anyOf in order to use the type null rework on open api specification v3.1.
It seems related to #1643.
I remain at your disposal for any feedback on the implementation.
I wish you a great day ☀️
Best regards ☮️