feat(python): use bytes type for binary WebSocket payloads #11441
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: User request from @patrickthornton
When AsyncAPI messages are marked with
contentType: application/octet-streamandpayload: { type: string, format: binary }, the Python SDK now generatesbytestype hints instead ofstrfor WebSocket message parameters.Changes Made
_is_binary_string()helper method to detect primitives withformat: "binary"validation_get_type_hint_for_primitive()to returnAST.TypeHint.bytes()for binary string primitivesTesting
bytesis not supported as a WebSocket message body type in Fern definitions - the binary format is set when AsyncAPI is converted to Fern IR)Human Review Checklist
_is_binary_stringlogic correctly accesses thePrimitiveType.v_2union structure and validation formatformat: "binary"from AsyncAPI definitionsLink to Devin run: https://app.devin.ai/sessions/24b9fb2e623047f584bb06e66893c15b