feat(cli): add response header parsing for success responses #11459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add responseHeaders field to HttpEndpoint in IR SDK definition - Update ResponseBodyConverter to parse response headers from OpenAPI specs - Update OperationConverter to pass response headers through to endpoint - Add test fixture for response headers with various header types - Update CLI versions.yml for v3.36.0 feature release Co-Authored-By: Colton Berry <coltonsberry@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Colton Berry <coltonsberry@gmail.com>
devin-ai-integration
bot
changed the title
Co-Authored-By: Colton Berry <coltonsberry@gmail.com>
Co-Authored-By: Colton Berry <coltonsberry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Requested by @coltondotio
Link to Devin run
Adds support for parsing response headers from OpenAPI specs. Response headers defined on success responses (2xx) are now captured in the IR and available for SDK generators and documentation. This complements the existing support for error response headers.
Changes Made
responseHeadersfield toHttpEndpointin the IR SDK definitionResponseBodyConverterto parse response headers from OpenAPI specs, including:OperationConverterto pass response headers through to the endpoint definitionresponse-headers) with various header types and examplesTesting
response-headersfixture with snapshot tests)Review Checklist
responseHeadersfield is correctly populated in generated IR snapshots