Skip to content

Conversation

@zarinn3pal
Copy link
Contributor

This PR adds a fix to AIM telemetry implementation . Both traces and metrics are logged and can be seen on the dashboard. Xai sample is modified to showcase the implementation

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zarinn3pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the GCP telemetry integration by introducing a new GcpTelemetry class. This centralizes the configuration and lifecycle management of tracing, metrics, and logging, ensuring a more robust and consistent telemetry experience. Key improvements include adjustments to metric export intervals, ensuring valid trace span durations for GCP, standardizing metric aggregation temporality, and enabling better log correlation. The changes are showcased through an updated XAI sample application.

Highlights

  • Refactored GCP Telemetry Configuration: The core logic for configuring GCP tracing, metrics, and logging has been consolidated into a new GcpTelemetry class, centralizing management and improving consistency.
  • Adjusted Metric Export Interval: The default metric export interval has been increased from 60 seconds to 5 minutes (DEFAULT_METRIC_EXPORT_INTERVAL_MS changed from 60000 to 300000) to potentially reduce export frequency and align with common practices.
  • Ensured Valid Trace Span Durations: A new TimeAdjustedSpan class was introduced to guarantee that all trace spans have an end_time strictly greater than their start_time, which is a requirement for proper ingestion by GCP Trace.
  • Standardized Metric Aggregation Temporality: The GenkitMetricExporter now explicitly forces AggregationTemporality.DELTA for all OpenTelemetry metric instrument types, ensuring consistent data representation across different telemetry components.
  • Enhanced Logging Correlation with Traces: Structlog integration within the GcpTelemetry class now injects GCP-compatible trace context into log entries, enabling better correlation between logs and traces in monitoring tools.
  • XAI Sample Integration: The xai-hello sample application has been updated to include the genkit-plugin-google-cloud and demonstrate the new GCP telemetry setup, showcasing both traces and metrics.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and well-executed refactoring of the Google Cloud telemetry implementation. The new GcpTelemetry class effectively encapsulates the configuration and lifecycle management of tracing, metrics, and logging, which greatly improves code organization and maintainability. The changes also include important fixes for compatibility with Google Cloud services, such as adjusting span end times for Cloud Trace and forcing DELTA temporality for Cloud Monitoring. The addition of telemetry to the xai-hello sample is a valuable way to demonstrate and test this new functionality. I've included a couple of suggestions for minor improvements to further enhance the code quality.

@zarinn3pal
Copy link
Contributor Author

image image image

@yesudeep yesudeep requested a review from MengqinShen January 31, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants