Skip to content

Conversation

@arai-a
Copy link
Contributor

@arai-a arai-a commented Dec 30, 2025

Fixed #5183

This does:

  • Add onFirstItemClick property to FilterNavigatorBar, which is called when the first committed item is clicked
    • FilterNavigatorBarListItem's onClick property now receives the index and the mouse event
    • FilterNavigatorBar calls either onPop or onFirstItemClick, passing either index or the mouse event
  • Let ProfileFilterNavigatorBar pass onFirstItemClick to FilterNavigatorBar when the "Full Range" is the only item
  • Do not create a button for "Full Range", in order to avoid nested clickable elements

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (1a808fe) to head (c1d8353).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5742      +/-   ##
==========================================
+ Coverage   85.64%   85.69%   +0.04%     
==========================================
  Files         313      314       +1     
  Lines       31013    31119     +106     
  Branches     8535     8561      +26     
==========================================
+ Hits        26562    26666     +104     
- Misses       4021     4023       +2     
  Partials      430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me with two nits.

@arai-a arai-a force-pushed the full-range-click-item branch from 69b235d to c1d8353 Compare January 8, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clickable area too small on page chooser

2 participants