feat: add steps support to templates #812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieppa
requested changes
Jan 26, 2026
Member
dieppa
left a comment
dieppa
left a comment
There was a problem hiding this comment.
This requires some changes and it's half done, the changeTemplate structure should be affected
- The
steps, unlike theapplyandrollback, it's a list , not an object. setStepsPayloadis expected by the TemplateExecutableTask to be a method in theChangeTemplateinterface, but it's notapplyandrollbackshould be marked as deprecated(and removed in the next PR)
| private Object configuration; | ||
| private Object apply; | ||
| private Object rollback; | ||
| private Object steps; |
| private Object configuration; | ||
| private Object apply; | ||
| private Object rollback; | ||
| private Object steps; |
| private Object configuration; | ||
| private Object apply; | ||
| private Object rollback; | ||
| private Object steps; |
| } | ||
|
|
||
| Method setStepsMethod = Arrays.stream(instance.getClass().getMethods()) | ||
| .filter(m -> "setStepsPayload".equals(m.getName())) |
Member
There was a problem hiding this comment.
this method is not present in the ChangeTemplate interface
| private Object configuration; | ||
| private Object apply; | ||
| private Object rollback; | ||
| private Object steps; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add steps support to templates