node: Fix generator ripgrep binary mappings and add missing arches #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhtt
reviewed
Dec 29, 2025
LorbusChris
force-pushed
the
ripgrep-fix
branch
from
f030d19 to
47030d5
Compare
…ures The @vscode/ripgrep package postinstall script expects specific binary variants for each architecture. This patch: 1. Adds backwards compatibility for aarch64 libc variants - Versions < 1.13.0 used gnu variant (aarch64-unknown-linux-gnu) - Versions >= 1.13.0 switched to musl (aarch64-unknown-linux-musl) - Both variants exist in different ripgrep-prebuilt releases 2. Adds missing architecture mappings for ppc64, riscv64, and s390x - These architectures are supported by @vscode/ripgrep - Uses gnu variants (only available option for these arches) This prevents the postinstall script from failing to find the cached binary and attempting to download from GitHub, which fails in offline build environments (RPM builds, air-gapped systems, etc). The mappings now match what the postinstall script expects based on the package version being used. See: https://github.com/microsoft/vscode-ripgrep/blob/main/lib/postinstall.js Assisted-by: Claude Code
LorbusChris
force-pushed
the
ripgrep-fix
branch
from
47030d5 to
6769d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @vscode/ripgrep package postinstall script expects specific binary variants for each architecture. This patch:
Fixes aarch64 to use musl variant instead of gnu
Adds missing architecture mappings for ppc64, riscv64, and s390x
Current code causes the postinstall script to fail to find the cached binary on aarch64 and attempt to download from GitHub, which fails in offline build environments (RPM builds, air-gapped systems, etc).
The mappings now match exactly what the postinstall script expects: https://github.com/microsoft/vscode-ripgrep/blob/main/lib/postinstall.js#L38-L47
Assisted-by: Claude Code