FDN-4400 Update generic-charts to v2.0.22

[team-foundation-git]

This PR contains the following updates:

Package	Update	Change
git@github.com:flowcommerce/generic-charts.git	patch	v2.0.20 -> v2.0.22

⚠️ This PR updates the shared Helm chart version.

Before merging:

1. Ensure your service is compatible with the new chart version

2. Review diff in PR with changes

3. Merge when ready to deploy this change

After merging, ArgoCD will automatically sync the new chart version.

---

Release Notes

flowcommerce/generic-charts (git@github.com:flowcommerce/generic-charts.git)

v2.0.22

Compare Source

v2.0.21

Compare Source

---

This PR has been generated by Renovate Bot.

Summary by CodeRabbit

• Chores
  • Updated chart dependencies to improve system stability and performance.

[coderabbitai]

📝 Walkthrough

Walkthrough

Two Argo CD Application deployment manifests are updated to bump the generic-charts dependency version from v2.0.20 to v2.0.22. The targetRevision field is modified in both deploy/dependency-api/app.yaml and deploy/dependency-www/app.yaml files.

Changes

Cohort / File(s)	Summary
Chart Version Bump deploy/dependency-api/app.yaml, deploy/dependency-www/app.yaml	Updated targetRevision for generic-charts repository from v2.0.20 to v2.0.22 in Argo CD Application specs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• FDN-4400 Update generic-charts to v2.0.20 #889: Updates the same targetRevision field for generic-charts in both app.yaml files, bumping from v2.0.19→v2.0.20.
• FDN-4400 Update generic-charts to v2.0.7 #876: Modifies the same Argo CD Application targetRevision fields for flowcommerce/generic-charts in the same deployment manifests.

Suggested reviewers

• arias-m
• gheine

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately summarizes the main change: updating the generic-charts dependency from v2.0.20 to v2.0.22, which is reflected in both modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[flow-tech]

Argo diff output for dependency-api:

===== /Service production/dependency ======
11c11
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== apps/Deployment production/dependency-api-live ======
16c16
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== datadoghq.com/DatadogMonitor datadog/dependency-api-errorrate ======
144d143
<   - generated:kubernetes

===== networking.istio.io/Gateway production/dependency-flow-io ======
17c17
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== networking.istio.io/VirtualService production/dependency-api-live ======
12c12
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

[flow-tech]

Argo diff output for dependency-www:

===== /Service production/dependency-www ======
11c11
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== apps/Deployment production/dependency-www-live ======
16c16
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== datadoghq.com/DatadogMonitor datadog/dependency-www-errorrate ======
144d143
<   - generated:kubernetes

===== networking.istio.io/Gateway production/dependency-www-flow-io ======
17c17
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

===== networking.istio.io/VirtualService production/dependency-www-live ======
12c12
<     helm.sh/chart: flow-generic-1.6.62
---
>     helm.sh/chart: flow-generic-1.6.63

[coderabbitai]

♻️ Duplicate comments (2)

deploy/dependency-www/app.yaml (2)

56-67: Same stale syncPolicy comment applies here.

Identical to the stale comment in deploy/dependency-api/app.yaml Lines 56–57 — remove if the transition is complete.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@deploy/dependency-www/app.yaml` around lines 56 - 67, Remove the stale
transitional comment above the syncPolicy block: locate the syncPolicy section
(the "syncPolicy:" key and its child keys "syncOptions:", "-
RespectIgnoreDifferences=true", "- CreateNamespace=false", "-
ApplyOutOfSyncOnly=true", "- ServerSideApply=true", "- PruneLast=true", and the
"automated:" block) and delete the leading comment lines that start with "##
Keep it commenting out during the transition process..." so the file no longer
contains the outdated transition note.

---

47-47: Same values.yaml compatibility check applies here.

Same concern as deploy/dependency-api/app.yaml Line 47 — confirm deploy/dependency-www/values.yaml is compatible with both v2.0.21 and v2.0.22 schemas.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@deploy/dependency-www/app.yaml` at line 47, Confirm that the values.yaml for
dependency-www is compatible with both schema v2.0.21 and v2.0.22 referenced by
targetRevision: v2.0.22: run a schema/values diff between the two chart
versions, update any renamed/removed keys or type changes in
deploy/dependency-www/values.yaml, add conditional/compatibility defaults or
migration logic for keys that differ, and document the compatibility test you
used so switching targetRevision back to v2.0.21 will not break deployment.

🧹 Nitpick comments (1)

deploy/dependency-api/app.yaml (1)

56-67: Stale comment contradicts the active syncPolicy.automated block.

Lines 56–57 read: "Keep it commenting out during the transition process to avoid auto sync..." but automated: prune: true, selfHeal: true is fully active. If the transition is complete, remove the comment to avoid future confusion.

🧹 Proposed cleanup

-  ## Keep it commenting out during the transition process to avoid auto
-  ## sync applying changes automatically until transition is completed.
   syncPolicy:

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@deploy/dependency-api/app.yaml` around lines 56 - 67, The YAML header comment
about "Keep it commenting out during the transition" contradicts the active
syncPolicy.automated block (syncPolicy.automated.prune and
syncPolicy.automated.selfHeal are enabled); remove or update that stale comment
so it matches current behavior (either delete the transitional note or change it
to state that automated sync/prune/selfHeal are intentionally enabled), and
ensure references to syncPolicy.syncOptions and syncPolicy.automated remain
consistent.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@deploy/dependency-www/app.yaml`:
- Around line 56-67: Remove the stale transitional comment above the syncPolicy
block: locate the syncPolicy section (the "syncPolicy:" key and its child keys
"syncOptions:", "- RespectIgnoreDifferences=true", "- CreateNamespace=false", "-
ApplyOutOfSyncOnly=true", "- ServerSideApply=true", "- PruneLast=true", and the
"automated:" block) and delete the leading comment lines that start with "##
Keep it commenting out during the transition process..." so the file no longer
contains the outdated transition note.
- Line 47: Confirm that the values.yaml for dependency-www is compatible with
both schema v2.0.21 and v2.0.22 referenced by targetRevision: v2.0.22: run a
schema/values diff between the two chart versions, update any renamed/removed
keys or type changes in deploy/dependency-www/values.yaml, add
conditional/compatibility defaults or migration logic for keys that differ, and
document the compatibility test you used so switching targetRevision back to
v2.0.21 will not break deployment.

---

Nitpick comments:
In `@deploy/dependency-api/app.yaml`:
- Around line 56-67: The YAML header comment about "Keep it commenting out
during the transition" contradicts the active syncPolicy.automated block
(syncPolicy.automated.prune and syncPolicy.automated.selfHeal are enabled);
remove or update that stale comment so it matches current behavior (either
delete the transitional note or change it to state that automated
sync/prune/selfHeal are intentionally enabled), and ensure references to
syncPolicy.syncOptions and syncPolicy.automated remain consistent.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98525e7 and dfd95fb.

📒 Files selected for processing (2)

• deploy/dependency-api/app.yaml
• deploy/dependency-www/app.yaml

[team-foundation-git]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.