DTDManager handles the subscription to the service stream #9635
+367
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
Jan 30, 2026
Comment on lines
+260
to
263
| if (_connection.value case final connection?) { | ||
| await connection.close(); | ||
| } | ||
| _connection.value = null; |
Member
Author
There was a problem hiding this comment.
I noticed that we were setting the connection to null without closing it first
elliette
commented
Jan 30, 2026
| _connection.value = connection; | ||
| // Close the previous connection. | ||
| if (previousConnection != null) { | ||
| await previousConnection.close(); |
Member
Author
There was a problem hiding this comment.
Before this change, we were closing the connection during the disconnect implementation. I moved it here to the connect implementation instead so that we wait for the new connection before closing the previous connection (this prevents us from dropping any service extension registration events we receive while reconnecting).
elliette
requested review from
a team,
DanTup,
bkonyi and
srawlins
and removed request for
a team,
bkonyi and
kenzieschmoll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9632
DTDManagernow subscribes to theServicestream, and broadcastsServiceRegisteredandServiceUnregisteredevents to any subscribers.Currently the
EditorClientis the only subscriber, but our AI Assistant will also need to subscribe to those events.FYI @DanTup I've changed the DTD reconnection logic a little bit. I tested the Flutter panel and Property Editor in VS Code, but you might want to verify as well.