-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix html in webview_flutter doc comment #10634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds 10 points to the score on pub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request addresses a documentation formatting issue in the webview_flutter package. Specifically, it escapes angle brackets in a doc comment to ensure correct rendering, which contributes to an improved score on pub.dev.
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
autosubmit label was removed for flutter/packages/10634, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
|
@stuartmorgan-g or @tarrinneal for secondary review |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@9705815...039a026 2026-01-07 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 66dd93f to f6ff152 (2 revisions) (flutter/packages#10746) 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] release action uses sub action for installing flutter (flutter/packages#10747) 2026-01-07 athom@google.com Fix html in webview_flutter doc comment (flutter/packages#10634) 2026-01-07 150208987+jalen-videotape@users.noreply.github.com [camera_web] Fixed crashing bug on camera_web 0.3.5 for Safari (flutter/packages#10595) 2026-01-07 engine-flutter-autoroll@skia.org Roll Flutter from 13b2b91 to 01d37bc (74 revisions) (flutter/packages#10745) 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] adjust github action, need to checkout repo before using local action (flutter/packages#10744) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This adds 10 points to the score on pub.
https://pub.dev/packages/webview_flutter/score