[camera] Adds support for video stabilization#11044
[camera] Adds support for video stabilization#11044ruicraveiro wants to merge 1 commit intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for video stabilization by adding getSupportedVideoStabilizationModes() and setVideoStabilizationMode() to the CameraController. The implementation includes updating CameraValue to store the current stabilization mode and providing comprehensive unit tests for the new functionality. The changes are well-structured and thoroughly tested. I have a couple of minor suggestions for improvement.
f57eb79 to
15bc49d
Compare
- Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in CameraController.
15bc49d to
c42ec72
Compare
|
@ruicraveiro Is this just the remainder of #7108 ? If so, you can just resolve the main PR to only include this part, and we can use that existing PR for the last package rather than having a new PR with new reviews. |
Ah!!! It is! :-) OK, I will do that as soon as I'm able to. |
|
BTW, maybe I can just force push the branch to that |
|
That should work (although it will mean we won't be able to easily see that the app-facing package code hasn't changed since the last review if you force-push, due to how GitHub differential reviews work). |
|
OK, to make your life easier, I have just rebased the 2 commits originally in PR 7108 on top of main and I'm adding a 3rd commit with what changed in the meantime. The only meaningful changes that I made were: I had the comment in this field incomplete: This message was still referring to the old name of the method before we refactored it: Everything else is a result of dart format (edit: and dart analyze) behaving differently between then and now. |
Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in CameraController.
Address issue flutter/flutter#89525.
It is the camera sub-PR for #7108.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3