Skip to content

[video_player_android] Remove usesCleartextTraffic#11075

Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom
mboetger:remove-uses-cleartext-traffic-video-player-android
Feb 25, 2026
Merged

[video_player_android] Remove usesCleartextTraffic#11075
auto-submit[bot] merged 5 commits intoflutter:mainfrom
mboetger:remove-uses-cleartext-traffic-video-player-android

Conversation

@mboetger
Copy link
Contributor

Removes deprecated usesCleartextTraffic.

Addresses: #182553

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@mboetger mboetger changed the title Remove uses cleartext traffic video player android [video_player_android] Remove usesCleartextTraffic Feb 19, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes the android:usesCleartextTraffic="true" attribute from the AndroidManifest.xml in the debug example application. This change addresses the deprecation of cleartext traffic usage, enhancing the security posture of the application by preventing unencrypted network communication. The change is minimal and directly targets the stated issue.

@stuartmorgan-g
Copy link
Collaborator

test-exempt: configuration change

@stuartmorgan-g
Copy link
Collaborator

This one should get an equivalent network config to allow for re-enabling

@Ignore("Doesn't run in Firebase Test Lab: https://github.com/flutter/flutter/issues/94748")
someday.

@mboetger
Copy link
Contributor Author

This one should get an equivalent network config to allow for re-enabling

@Ignore("Doesn't run in Firebase Test Lab: https://github.com/flutter/flutter/issues/94748")

someday.

This one already has a network security config actually, which is why I didn't add it - just hooked up the AndroidManifest.xml:

https://github.com/flutter/packages/blob/main/packages/video_player/video_player_android/example/android/app/src/main/res/xml/network_security_config.xml#L4

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. LGTM

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2026
@auto-submit auto-submit bot merged commit b9ee0b3 into flutter:main Feb 25, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: video_player platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants