Temporarily disable super_editor tests #480
Open
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do a hard breaking change in Flutter that affects
package:super_editor: flutter/flutter#180436To workaround the hard breaking change, we will:
Why this is necessary...
To fix flutter/flutter#161592, we need to pass additional styling information to the web engine.
Historically, we plumb text styling information through TextInputConnection.setStyle(...). However, every time we add a parameter here, it creates a breaking change for super_editor's TextInputConnectionDecorator as it implements
TextInputConnection.To stop this cycle, we will do a one-time breaking change to move to a more extensible pattern:
TextInputConnection.setStyle(...).This pattern lets us add more text input styling properties without breaking super_editor again.
To handle this breaking change, the following code will need to be added to super_editor's TextInputConnectionDecorator:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.