fix: datadog metrics should provide http status code on error if non-2xx response #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmiller-gusto
requested review from
aryan9600 and
stefanprodan
as code owners
…2xx response currently the log line exposes the error, however that's always going to be nil based on the check just above it. This provides better visibility into the failure reason Signed-off-by: Erik Miller <erik.miller@gusto.com>
erikmiller-gusto
force-pushed
the
main
branch
from
a50fc33 to
ffddfd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the log line exposes the error, however that's always going to be nil based on the check just above it. This provides better visibility into the failure reason
Previously:
Now: