-
Notifications
You must be signed in to change notification settings - Fork 166
fix: schedule grid overflow - contain within container #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: schedule grid overflow - contain within container #1499
Conversation
Added CSS to prevent schedule grid from overflowing its container: - overflow-x: auto allows horizontal scrolling when needed - max-width: 100% constrains the grid to container width This ensures the schedule widget stays within the white content box on all screen sizes and with varying numbers of rooms.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds CSS constraints to the schedule grid to keep it within its container by enabling horizontal scrolling and limiting width to the container, preventing overflow on various screen sizes and room counts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider whether targeting
#fahrplan.gridis specific enough for all schedule layouts using this component; if other variants of the schedule grid exist (different IDs/classes or nested containers), you may want a more generic selector to ensure consistent overflow behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether targeting `#fahrplan.grid` is specific enough for all schedule layouts using this component; if other variants of the schedule grid exist (different IDs/classes or nested containers), you may want a more generic selector to ensure consistent overflow behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a CSS overflow issue where the schedule grid element would overflow its container. The fix adds two CSS properties to constrain the grid and enable horizontal scrolling when needed.
- Added
overflow-x: autoto enable horizontal scrolling for wide schedule grids - Added
max-width: 100%to constrain the grid within its container
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Could you test with the 1366 x 768 screen? |
Tested at 1366x768 - the schedule grid is contained within the white container with a horizontal scrollbar when needed. Regarding width: 100% it's safe here because the parent element #main-container.main-schedule is already constrained with min-width: min-content and has explicit margin: 0 auto centering. However, if you still prefer max-width: 100%, Ill change it |
This is the expected explanation and it is Ok to use |
|
I am not sure about this. I think we should for now stay close to Pretalx. The implementation here overflows to the right whereas the current implementation also moves it to the left. There is no perfect solution so far. We need to think this through carefully. |
|
Sorry as mentioned above this does not make more sense than the previous implementation. Hence closing it. We need to discuss the approach face to face before PRs that proceed in this direction. Also there should be an issue that is open first - before a PR - where this can be discussed. |
Added CSS to prevent schedule grid from overflowing its container:
This ensures the schedule widget stays within the white content box on all screen sizes and with varying numbers of rooms.
Screen.Recording.2025-12-14.at.3.53.05.PM.mov
Before
Screen.Recording.2025-12-14.at.3.53.50.PM.mov
Summary by Sourcery
Bug Fixes: