Skip to content

Conversation

@ArnavBallinCode
Copy link
Member

@ArnavBallinCode ArnavBallinCode commented Dec 14, 2025

Added CSS to prevent schedule grid from overflowing its container:

  • overflow-x: auto allows horizontal scrolling when needed
  • max-width: 100% constrains the grid to container width

This ensures the schedule widget stays within the white content box on all screen sizes and with varying numbers of rooms.

Screen.Recording.2025-12-14.at.3.53.05.PM.mov

Before

Screen.Recording.2025-12-14.at.3.53.50.PM.mov

Summary by Sourcery

Bug Fixes:

  • Prevent the schedule grid from overflowing its container by constraining its width and enabling horizontal scrolling when necessary.

Added CSS to prevent schedule grid from overflowing its container:
- overflow-x: auto allows horizontal scrolling when needed
- max-width: 100% constrains the grid to container width

This ensures the schedule widget stays within the white content box
on all screen sizes and with varying numbers of rooms.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds CSS constraints to the schedule grid to keep it within its container by enabling horizontal scrolling and limiting width to the container, preventing overflow on various screen sizes and room counts.

File-Level Changes

Change Details Files
Constrain the schedule grid (#fahrplan.grid) to its container and enable horizontal scrolling when content is wider than the container.
  • Add a CSS rule targeting the schedule grid container to set horizontal overflow to auto.
  • Limit the schedule grid container width to 100% so it does not exceed its parent container.
app/eventyay/static/agenda/css/_agenda.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider whether targeting #fahrplan.grid is specific enough for all schedule layouts using this component; if other variants of the schedule grid exist (different IDs/classes or nested containers), you may want a more generic selector to ensure consistent overflow behavior.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether targeting `#fahrplan.grid` is specific enough for all schedule layouts using this component; if other variants of the schedule grid exist (different IDs/classes or nested containers), you may want a more generic selector to ensure consistent overflow behavior.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CSS overflow issue where the schedule grid element would overflow its container. The fix adds two CSS properties to constrain the grid and enable horizontal scrolling when needed.

  • Added overflow-x: auto to enable horizontal scrolling for wide schedule grids
  • Added max-width: 100% to constrain the grid within its container

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hongquan
Copy link
Member

Could you test with the 1366 x 768 screen?
Btw, using width: 100% is unsafe (it will stretch small elements). There should be better reason to use it (for example you make sure the element is already constrainted by a parent) than just "to be consistent with other rule".

@ArnavBallinCode
Copy link
Member Author

Could you test with the 1366 x 768 screen? Btw, using width: 100% is unsafe (it will stretch small elements). There should be better reason to use it (for example you make sure the element is already constrainted by a parent) than just "to be consistent with other rule".

Tested at 1366x768 - the schedule grid is contained within the white container with a horizontal scrollbar when needed.

Regarding width: 100% it's safe here because the parent element #main-container.main-schedule is already constrained with min-width: min-content and has explicit margin: 0 auto centering.

However, if you still prefer max-width: 100%, Ill change it
main fix is overflow-x: auto width property just ensures it is in container bounds

@hongquan
Copy link
Member

100% it's safe here because the parent element #main-container.main-schedule is already constrained with min-width: min-content

This is the expected explanation and it is Ok to use width: 100%.

@mariobehling
Copy link
Member

I am not sure about this. I think we should for now stay close to Pretalx. The implementation here overflows to the right whereas the current implementation also moves it to the left. There is no perfect solution so far. We need to think this through carefully.

@mariobehling
Copy link
Member

Sorry as mentioned above this does not make more sense than the previous implementation. Hence closing it. We need to discuss the approach face to face before PRs that proceed in this direction. Also there should be an issue that is open first - before a PR - where this can be discussed.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Eventyay Next Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants