Skip to content

Replace sprockets-sass with dartsass-sprockets#2649

Open
spamguy wants to merge 4 commits intofreeCodeCamp:mainfrom
spamguy:sass
Open

Replace sprockets-sass with dartsass-sprockets#2649
spamguy wants to merge 4 commits intofreeCodeCamp:mainfrom
spamguy:sass

Conversation

@spamguy
Copy link
Contributor

@spamguy spamguy commented Feb 11, 2026 •
edited
Loading

This PR modernizes the Sass compilation pipeline by migrating from the deprecated sprockets-sass gem to dartsass-sprockets. Closes #2214 and #2450.

After merging, the way should be clear to upgrade various other gems previously blocked by Sass.

Highlights

  • Updated sprockets to v4
  • Replaced sprockets-sass with dartsass-sprockets in the build pipeline
  • Added manual precompilation of .scss.erb files to the Thor task. dart-sass doesn't handle ERB preprocessing automatically, so this step is now explicit in the build process
  • Removed deprecated @import statements in favor of @use

Testing Notes

There should be no user-facing impact. I did my utmost to confirm this through smoke tests, env comparisons, unit tests, etc. Verifying the quality of a production build on my li'l dev machine is possibly beyond my understanding, but will gladly take any advice.

@spamguy
Replace sprockets-sass with dartsass-sprockets.
ebd756d 
Add manual precompile of .scss.erb files to thor task, since dart-sass is no longer responsible for it.

Remove @import statements deprecated by dart-sass, and add them as @use clauses in individual modules.

Replace deprecated darken() functions with color.adjust(). Update copyright year in README.
@spamguy spamguy requested a review from a team as a code owner February 11, 2026 04:36
@socket-security
Copy link

socket-security bot commented Feb 11, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedsprockets@​3.7.5 ⏵ 4.2.289100100100100
Addeddartsass-sprockets@​3.2.197100100100100

View full report

simon04
simon04 reviewed Feb 14, 2026
View reviewed changes
simon04
simon04 reviewed Feb 14, 2026
View reviewed changes
lib/tasks/sprites.thor
Comment on lines +59 to +61
# SCSS wrapped in ERB templates must be compiled manually.
compile_scss_erb

Copy link
Contributor

@simon04 simon04 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dartsass-sprockets seems to handle .sass.erb: https://github.com/tablecheck/dartsass-sprockets/blob/d0fefd07b631c1326907bcf4fb811fc3a462acdd/lib/sassc/rails/importer.rb#L55-L57

Not sure if it is of any help?

Copy link
Contributor Author

@spamguy spamguy Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to activate it then. It isn't automatic behavior, at least. Documentation goes into great detail about Rails' asset pipeline without discussing Rails-less envs at all.

Copy link
Contributor Author

@spamguy spamguy Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon04 The importers you linked to are Rails-directed and I don't think they can be used for our purposes. Given there are exactly two .scss.erb files (environment.scss.erb could probably be rewritten, so possibly one file), my approach is probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon04 simon04 simon04 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EOL warning after bundle install

2 participants

@spamguy @simon04