Conversation
Signed-off-by: Adam Ludes <adam.ludes@whalebone.io>
Signed-off-by: Adam Ludes <adam.ludes@whalebone.io>
Signed-off-by: Adam Ludes <adam.ludes@whalebone.io>
deerbone
changed the title
I'm planning to get that one merged over the next few days, I'll ping you once ready so you can pull those changes. Thanks! 🙏🏻 |
| ) | ||
|
|
||
| // ImposterHandler create specific handler for the received imposter | ||
| // Handler create specific handler for the received imposter |
joanlopez
left a comment
joanlopez
left a comment
There was a problem hiding this comment.
Thanks so much for this @deerbone, this is also a nice idea. However, my feeling is that it might have conflicts with #177. For instance, I guess that applyTemplate will need to be part of the writeBody function.
So, let's try to get the other one merged, so later we can more easily see if there's any conflict with this changeset and do a final review.
🙌🏻 🙇🏻
@joanlopez for sure, there will be conflicts but nothing major that I can't resolve. I'll revisit this PR once the other one is merged. |
2 participants
This PR introduces preloading response body into memory before the mockserver starts. This makes it easier to spot bugs in a configuration that uses a lot of BodyFiles. Any issue with the files is now clearly logged on startup. Watcher still works even with this change.
This change improves the speed of the server since the data doesn't need to get loaded every time a request arrives.
I have also fixed the imposter base path bug, that I later realized is already implemented by #173. I can remove it, but it would be nice to have that fix merged since the main branch is harder to use because of it.